Use default embed config in e2e tests #16688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
e2e-default-config
branch
3 times, most recently
from
54cc3bd
to
22076e8
Compare
serathius
force-pushed
the
e2e-default-config
branch
from
22076e8
to
8fac72e
Compare
|
cc @ahrtr |
ahrtr
reviewed
Oct 5, 2023
Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
e2e-default-config
branch
from
8fac72e
to
c1fb2c2
Compare
serathius
commented
Oct 5, 2023
| } | ||
| cfg.ServerConfig.InitialClusterToken = "new" |
There was a problem hiding this comment.
Note, there are tests that depend on this value being exact "new". I might do a followup PR to remove this.
ahrtr
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16673
We need to ensure that we are running the default etcd config so we can easily distinguish when we are providing non-defaults.