Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce --wait-cluster-ready-timeout flag causing linearizability issue #16672

Closed
wants to merge 1 commit into from

Conversation

serathius
Copy link
Member

@serathius serathius commented Sep 30, 2023

Reproduces #16666 but finds that --wait-cluster-ready-timeout could even cause linearizability issue in single node cluster.

@serathius
Copy link
Member Author

serathius commented Sep 30, 2023

Selection_007
Revision is goes back by 1, for couple of requests and then it is restored. Consistent with predictions in #16666

Think this is combination of 2 issues, #16666 and I expect that in single node clusters, leader trusts it's own db state and doesn't check readIndex, which during bootstrap can be newer then db state.

@ahrtr
Copy link
Member

ahrtr commented Sep 30, 2023

Please integrate etcd-io/raft#105 and try again.

@serathius
Copy link
Member Author

serathius commented Sep 30, 2023

Will do, however I think the etcd-io/raft#105 is not a proper solution. I expect it will fix the issue, but I don't think the approach is correct. Responsed on PR with my thoughts.

@k8s-ci-robot
Copy link

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 6edc12a link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@serathius serathius closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants