Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to robustness tests to prevent issues like --experimental-wait-cluster-ready-timeout #16673

Open
serathius opened this issue Sep 30, 2023 · 0 comments

Comments

@serathius
Copy link
Member

serathius commented Sep 30, 2023

What would you like to be added?

--experimental-wait-cluster-ready-timeout showed in #16672 that adding features to etcd is hard, especially if those are not well tested as they are optional. So testing just the default configuration is not enough.

Some ideas on preventing similar issues:

  • Robustness tests should validate all possible configurations. To get good coverage we should look through etcd optional flags and pick a random subset of them.
  • Testing etcd bootstrap is as important. We might extend failpoint injection from being HTTP only, to also environment variable based.
  • Sleep failpoints! We should implement them already
  • Test adding and removing members. Especially in context of migration to v3 store.

Why is this needed?

Correctnes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants