Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference.md #83

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update reference.md #83

merged 2 commits into from
Dec 14, 2023

Conversation

Degoot-AM
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 11, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials/compare/md-outputs..md-outputs-PR-83

The following changes were observed in the rendered markdown documents:

 md5sum.txt   | 2 +-
 reference.md | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-14 14:10:44 +0000

github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Degoot-AM for your clarifications here. Do you recommend using the expression 'parameter values' instead of only 'parameters'? Because I mostly use the latter in episodes I'm writing. Tagging @amanda-minter as the editor of these entries.

learners/reference.md Outdated Show resolved Hide resolved
@avallecam avallecam mentioned this pull request Dec 12, 2023
@Degoot-AM Degoot-AM closed this Dec 13, 2023
@avallecam
Copy link
Member

@Degoot-AM I think this is a relevant edit because this is improving the writing. Do you agree if we reopen this PR to resolve the conversation and merge?

@Degoot-AM
Copy link
Contributor Author

OK.

@Degoot-AM Degoot-AM reopened this Dec 14, 2023
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
Co-authored-by: Andree Valle Campos <[email protected]>
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
@avallecam avallecam self-requested a review December 14, 2023 16:51
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'll rebase this branch locally and then I'll merge it to main

@avallecam avallecam merged commit b53fb17 into main Dec 14, 2023
3 checks passed
@avallecam avallecam deleted the Degoot-AM-patch-2 branch December 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants