Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LatinR slides #274

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add LatinR slides #274

merged 2 commits into from
Jun 10, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jun 6, 2024

  • The post specifies a license if you don't want to use the default CC BY
  • All authors have an ORCID iD
  • Relevant keywords / tags has been added. In particular, if you want your post to be shared on R-bloggers, you must tag it with R
  • Images or other external resources have been committed and pushed
  • The post uses pure quarto syntax, rather than HTML or R code, unless necessary

Right before merging:

  • The date field has been updated
  • All reviewers have been acknowledged in a short paragraph
  • A PR has been opened in the blueprints to link to this post
  • The post has been re-rendered and content of the _freeze/ folder is up-to-date

I'm not super happy about adding large binaries in the git repo but at the same time, it seems risky to host externally as it increases the change to lose the link between this page and the hosting location. Open to suggestions.

@Bisaloo Bisaloo requested a review from chartgerink June 6, 2024 10:33
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for tourmaline-marshmallow-241b40 ready!

Name Link
🔨 Latest commit cce8d47
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/666191b2688a5f000815c114
😎 Deploy Preview https://deploy-preview-274--tourmaline-marshmallow-241b40.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chartgerink chartgerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bisaloo!

I agree with respect to the binaries. May it be an option to host them on the data.org CMS instead?

For what it's worth, it looks like good so happy to approve. A note from my end, which occurred for other presentations too, is that the files auto-download in my browser (Firefox). I personally don't think this is expected and if it was any other website, it would also make me distrust the files a bit. In Safari they get embedded as iframes, as I would expect. Do you want me to report an issue for this?

@Bisaloo
Copy link
Member Author

Bisaloo commented Jun 6, 2024

Is it #118? I think it's something on your end and you likely get the same behaviour on all website but please let me know if there's something we can change.

@chartgerink
Copy link
Member

chartgerink commented Jun 6, 2024

Thanks - does seem to be caused by the settings.

@Bisaloo Bisaloo merged commit 54ba93c into main Jun 10, 2024
9 checks passed
@Bisaloo Bisaloo deleted the latinr-slides branch June 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants