Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal checking function to reduce duplication #161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use internal checking function to reduce duplication #161

wants to merge 3 commits into from

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Aug 14, 2024

  • First commit creates an internal function containing checks common to all the cfr_() function
  • Second commit uses a collection so that the input data is completely validated in one go, and an error message with all the issues is returned. This prevents the user from having to try and error multiple times, with a different error message each time.

@adamkucharski
Copy link
Member

Thanks. Will review and merge into the latest 0.1.2 release PR #168 is complete (as seems like this is probably best sequence given CRAN submission was in limbo while this PR was added).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkucharski adamkucharski Awaiting requested review from adamkucharski

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bisaloo @adamkucharski