Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: io: don't use mutable object as default value #2086

Merged
merged 1 commit into from
Oct 1, 2024
Merged

build: io: don't use mutable object as default value #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions litex/build/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,13 @@ def __init__(self, i, o, clk):
self.sync.sdrio += o.eq(i)

class SDRIO(Special):
def __init__(self, i, o, clk=ClockSignal()):
def __init__(self, i, o, clk=None):
assert len(i) == len(o) == 1
Special.__init__(self)
self.i = wrap(i)
self.o = wrap(o)
if clk is None:
clk = ClockSignal()
self.clk = wrap(clk)
self.clk_domain = None if not hasattr(clk, "cd") else clk.cd

Expand Down Expand Up @@ -117,14 +119,14 @@ def __init__(self, io, o, oe, i, clk):
self.specials += Tristate(io, _o, _oe, _i)

class SDRTristate(Special):
def __init__(self, io, o, oe, i, clk=ClockSignal()):
def __init__(self, io, o, oe, i, clk=None):
assert len(i) == len(o) == len(oe)
Special.__init__(self)
self.io = wrap(io)
self.o = wrap(o)
self.oe = wrap(oe)
self.i = wrap(i)
self.clk = wrap(clk)
self.clk = wrap(clk) if clk is not None else ClockSignal()

def iter_expressions(self):
yield self, "io" , SPECIAL_INOUT
Expand All @@ -140,11 +142,13 @@ def lower(dr):
# DDR Input/Output ---------------------------------------------------------------------------------

class DDRInput(Special):
def __init__(self, i, o1, o2, clk=ClockSignal()):
def __init__(self, i, o1, o2, clk=None):
Special.__init__(self)
self.i = wrap(i)
self.o1 = wrap(o1)
self.o2 = wrap(o2)
if clk is None:
clk = ClockSignal()
self.clk = clk if isinstance(clk, str) else wrap(clk)

def iter_expressions(self):
Expand All @@ -159,11 +163,13 @@ def lower(dr):


class DDROutput(Special):
def __init__(self, i1, i2, o, clk=ClockSignal()):
def __init__(self, i1, i2, o, clk=None):
Special.__init__(self)
self.i1 = wrap(i1)
self.i2 = wrap(i2)
self.o = wrap(o)
if clk is None:
clk = ClockSignal()
self.clk = clk if isinstance(clk, str) else wrap(clk)

def iter_expressions(self):
Expand All @@ -189,7 +195,7 @@ def __init__(self, io, o1, o2, oe1, oe2, i1, i2, clk):
self.specials += Tristate(io, _o, _oe, _i)

class DDRTristate(Special):
def __init__(self, io, o1, o2, oe1, oe2, i1, i2, clk=ClockSignal()):
def __init__(self, io, o1, o2, oe1, oe2, i1, i2, clk=None):
Special.__init__(self)
self.io = io
self.o1 = o1
Expand All @@ -198,7 +204,7 @@ def __init__(self, io, o1, o2, oe1, oe2, i1, i2, clk=ClockSignal()):
self.oe2 = oe2
self.i1 = i1
self.i2 = i2
self.clk = clk
self.clk = clk if clk is not None else ClockSignal()

def iter_expressions(self):
yield self, "io" , SPECIAL_INOUT
Expand Down
Loading