BIOS: Add BOOTP support #2070
Open
BIOS: Add BOOTP support #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Breithaupt <[email protected]>
By moving from platform dependent types like `unsigned int` to cross-platform types like `uint32_t`, the behavior will remain as expected even on different platforms/compilers. I got some warnings when compiling for the simulator that hinted at a potential problem with the previous code. Signed-off-by: Matthias Breithaupt <[email protected]>
This adds support for UDP broadcasts and a helper function to get the currently set IP. These changes are required for BOOTP support. Signed-off-by: Matthias Breithaupt <[email protected]>
This adds BOOTP support as per RFC 951 and RFC 1532. Since most recent BOOTP servers seem to require the magic cookie defined in RFC 1533, this is also included. N.b.: the secs field is set to the uptime, even though RFC 1532 specifies this as the time since the first BOOTREQUEST. Since the BIOS usually won't be running for that long and the field is often ignored by servers, this felt like a reasonable compromise. Signed-off-by: Matthias Breithaupt <[email protected]>
This changes netboot to first try getting IPs and filename via BOOTP. If `netboot` is run multiple times, the assigned values are cached. To update this cache, a new command `bootp` has been added that will always make a new request to the BOOTP server. After updating the cache, `netboot` can be run again. Signed-off-by: Matthias Breithaupt <[email protected]>
|
Thanks @m-byte, this looks very interesting. I haven't yet closely looked at the code, but by default, do we still have the previous behavior with static IPs and no requirement for a BOOTP server on the other side? If not, I would prefer keeping it and enabling BOOTP through a build parameter. |
|
@enjoy-digital it falls back to previous behavior after 3 failed attempts, with a relatively short time between those attempts (relative to the tftp timeout). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few commits that enable BOOTP support in BIOS.
With this, it is possible to set IPs and filename from a server/computer. This simplifies usage of multiple devices in the same network.