Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hbs plugin not resolving .hbs due to broken Regex #2151

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix hbs plugin not resolving .hbs due to broken Regex #2151

merged 1 commit into from
Oct 9, 2024

Commits on Oct 9, 2024

  1. Fix hbs plugin not resolving .hbs due to broken Regex 

    The Regex in `syntheticJStoHBS` was broken.

Given a TO .hbs such as `components/json/index.hbs`, the hbs rollup would need to resolve that from a module id of `components/json/index.js` to the actual `components/json/index.hbs` file on disk. But with the broken regex, it tried instead to find `components.hbson/index.hbs`!

Added some unit tests (that failed without the fix) to prevent regressions.
    @simonihmig
    simonihmig committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3396ce9 View commit details
    Browse the repository at this point in the history