Fix hbs plugin not resolving .hbs due to broken Regex #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Regex in `syntheticJStoHBS` was broken. Given a TO .hbs such as `components/json/index.hbs`, the hbs rollup would need to resolve that from a module id of `components/json/index.js` to the actual `components/json/index.hbs` file on disk. But with the broken regex, it tried instead to find `components.hbson/index.hbs`! Added some unit tests (that failed without the fix) to prevent regressions.
simonihmig
commented
Oct 9, 2024
| const testCases = [ | ||
| ['foo.js', 'foo.hbs'], | ||
| ['foo.js?qp', 'foo.hbs?qp'], | ||
| ['foo/json.js', 'foo/json.hbs'], |
There was a problem hiding this comment.
This is the case that failed before:
NullVoxPopuli
approved these changes
Oct 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Regex in
syntheticJStoHBSwas broken, introduced in #2121. /cc @patricklxGiven a single .hbs file (TO) such as
components/json/index.hbs, the hbs rollup would need to resolve that from a module id ofcomponents/json/index.jsto the actualcomponents/json/index.hbsfile on disk. But with the broken regex, it would instead try to resolve tocomponents.hbson/index.js!Added some unit tests (that failed without the fix) to prevent regressions.
🚨 Note that the same bug exists on
mainalready, given that #1855 was done before backporting tostable! So maybe #2144 should also include this and the other recent changes onstable? /cc @mansona