Stop incoming call ringing if answered on another device.

[bmarty]

Content

First commit is code cleanup.

Observe if the user is in the call. If the call is still ringing, it will stop ringing and do not display the "missing call" notification.

Motivation and context

See element-hq/element-meta#2599

Screenshots / GIFs

Tests

• Alice is logged in on EXA
• Alice is also logged in on EW
• Bob calls Alice using Element Call
• Alice EXA is ringing
• Alice answers on Element Web

Observe that Alice phone is not ringing anymore and the notification about the (missed) call is not displayed

Also check that the code behaves correctly if Aliace answers the call from EXA.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[bmarty]

Note that if the call is not ringing anymore we will run this onEach block because we are still observing the roomInfoFlow, but there is some filtering on incomingCallTimedOut that saves us.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bn6yoW

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.98%. Comparing base (cf9dbc6) to head (f372295).
Report is 20 commits behind head on develop.

Files with missing lines	Patch %	Lines
...roid/features/call/impl/utils/ActiveCallManager.kt	40.00%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3842      +/-   ##
===========================================
- Coverage    82.98%   82.98%   -0.01%     
===========================================
  Files         1783     1783              
  Lines        44971    44976       +5     
  Branches      5289     5292       +3     
===========================================
+ Hits         37320    37322       +2     
- Misses        5805     5808       +3     
  Partials      1846     1846              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.