Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Regression on: Stopping ongoing (CallKit) ringing if the other devices takes the call #2599

Open
3 tasks done
fkwp opened this issue Oct 25, 2024 · 2 comments
Open
3 tasks done

Comments

@fkwp
Copy link

fkwp commented Oct 25, 2024

Description

We have a regression on stopping ongoing call ringing if the other devices meanwhile takes the call:

  • Using Element X 1.9.3 (134) on iPad
  • If the app is in foreground ringing stops
  • During Lockscreen or if the app is in background ringing/CallKit does NOT stop

(same was reported for Element X on Android)

Acceptance criteria

  • Call ringing stops of the call is meanwhile picked up by another device of that user

Leads

Being discussed here: https://matrix.to/#/!yuFzMhMqKzNFvoLqcJ:one.ems.host/$-5uGJAL-TIJwvkNOVzKgYgaFrviOHC9VPgQ0CPrTbVc?via=matrix.org&via=element.io&via=robin.town

element-hq/element-x-ios#3442 included https://github.com/matrix-org/matrix-rust-sdk/blob/bb55493a47fafb5f45c0e337cb076252d101702a/crates/matrix-sdk-ui/src/room_list_service/mod.rs#L90 which was the necessary fix to get m.call.member state synced into the App.

Now I am wondering if we need something similar for the push notification workers.

Size estimate

None

Dependencies

  • None

Out of scope

  • Nothing

Open questions

No response

Subtasks

Android

  1. PR-Bugfix

iOS

  1. pr-bugfix
  2. pr-bugfix

Rust

No tasks being tracked yet.

Other

No tasks being tracked yet.

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
@fkwp
Copy link
Author

fkwp commented Nov 7, 2024

@fkwp
Copy link
Author

fkwp commented Nov 12, 2024

Tested on Android 0.7.4 nightly (40007040, 11:12AM) which still keeps ringing if:

  • the caller hangs up the call
  • the call is taken by another device of the callee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants