-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: account declaration test with katana #734
Conversation
Sorry for the delay, I need a bit more time to understand what is happening in the tests and what exact cases they protect us from. At this point it seems like a complicated way to verify request-response JSON roundtrip :) |
Inside the account_declare.rs is a starkli_declare_workflow_test. If a user would call starkli declare <contract.json> file, these functions would be called on a starknet node. Instead of a live starknet node, I have created a mock node where we can control what kind of response can come. For next step, I was thinking of same starkli_declare_workflow_test, but instead of on mock starknet node, we would be starting katana and would query same requests on development node in this test environment. This would be done in scope of this issue: |
As far as I recall, the goal was to check the integration with the live testnet node, to make sure that production workflow can run through Beerus. If I'm being completely honest, I don't see how mock-based tests check this integration.
This should have been the only step, but against live testnet node. We will still need to run the tests against live node, even if tests against mocks and/or katana succeed. And if we have tests that run successfull against the live node, I personally consider extra testing against mocks and/or katana as redundant. |
cd13825
to
3a21504
Compare
Another thought on mock tests: #730 (comment) They might be very useful if we take PRs from external contributors into account. |
f487bce
to
bb8fb1c
Compare
bb8fb1c
to
0b1f46f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % please extract CLOBs to files before merging
Added tests that check Beerus functions used for account declaration with katana node