Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: starkli declare workflow in test #730

Closed
Tracked by #694
ICavlek opened this issue Jul 31, 2024 · 2 comments · Fixed by #759
Closed
Tracked by #694

test: starkli declare workflow in test #730

ICavlek opened this issue Jul 31, 2024 · 2 comments · Fixed by #759
Assignees

Comments

@ICavlek
Copy link
Contributor

ICavlek commented Jul 31, 2024

Create integration test with mock starknet node where beerus requests are going to simulate starkli declare workflow function calls:

  • starknet_chainId
  • starknet_getClass
  • starknet_chainId
  • starknet_getNonce
  • starknet_specVersion
  • starknet_estimateFee
  • starknet_addDeclareTransaction
@ICavlek ICavlek self-assigned this Jul 31, 2024
@ICavlek ICavlek linked a pull request Aug 1, 2024 that will close this issue
@ICavlek
Copy link
Contributor Author

ICavlek commented Aug 27, 2024

It has been decided that mock tests are redundant.

@sergey-melnychuk
Copy link
Collaborator

Mocks may be not as redundant as I thought actually. For the external contributor flow, GitHub doesn't propagate repository secrets (in order not to leak them, this is expected). But in practice it means that no PR from external contributors can run integration tests properly.

In such case mock tests might be the way to go - hermetic check of request/response invariants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants