Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning Logo Usage #67

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Aligning Logo Usage #67

wants to merge 5 commits into from

Conversation

egekorkan
Copy link
Member

This PR:

  • Aligns readme like in other repos
  • removes the redundant svgs and pngs from this repo
  • changes the header html to use the logo (Warning: I could not test it in this laptop due to dev environment issues. Until I go to my private machine, I will create the PR and maybe it works as I imagined it)

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for thingweb-preview ready!

Name Link
🔨 Latest commit 16c7ae0
🔍 Latest deploy log https://app.netlify.com/sites/thingweb-preview/deploys/65ae9d764885bf0008942269
😎 Deploy Preview https://deploy-preview-67--thingweb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egekorkan
Copy link
Member Author

The preview gets the wrong color scheme preference from my browser. At the same time, given that we do not have a dark scheme for the website, should we only use the light scheme?

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I would remove logo.png and replace it with some https://raw.githubusercontent.com link to another repository...

Moreover, since I don't think we have dark mode we don't need that complexity unless we come up with a dark-mode style

@egekorkan
Copy link
Member Author

I am not sure if I would remove logo.png and replace it with some https://raw.githubusercontent.com link to another repository...

Do you have the concern due to performance issues? I would be fine to not remove it since it's a one off case. However it still makes sense since the browser can cache it anyways amd might be even faster (someone who uses GitHub visit the webpage for the first time)

@danielpeintner
Copy link
Member

The concern I have is that it is a "website" which gets rendered in the end and I would tend to say the images should be in the same repo. Pointing to other repos etc makes the whole thing rather fragile but maybe it is just me that feels like this..

@egekorkan
Copy link
Member Author

egekorkan commented Jan 26, 2024

Call on 26.01:

  • @egekorkan will revert back to png in this repo.
  • We will remove the PSD file since we don't use the logos anymore.
  • The fonts.zip is still relevant the rest in the designcrowd can be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants