Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thingweb website redesign #82

Merged

Conversation

SergioCasCeb
Copy link
Contributor

@SergioCasCeb SergioCasCeb commented Oct 4, 2024

Website preview: Thingweb website

Everything in this PR:

  • Overall new design for the website utilizing Docusaurus
  • New landing page
    • Hero banner
    • Value proposition section
    • Worklfows section (still under construction)
    • Tools section
    • Services section
    • Community section (Adopters list)
  • Docs page for documentation
  • Services page and hands-on page (currently just a copy of the old one)

Also coming in this PR:

  • Google Analytics banner
  • Feeback prompt/icon

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for thingweb-preview failed.

Name Link
🔨 Latest commit aba62e9
🔍 Latest deploy log https://app.netlify.com/sites/thingweb-preview/deploys/6716a29228431a000866d51a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielpeintner this should not be needed anymore right? It is mentioned at #67 (comment) but it is old

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it should not be needed anymore. Does it make sens to store them "somewhere".. or is the GitHub archive enough?

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find some more comments below... based on the the rendered version at https://thingweb.netlify.app/

Intendation in code snippets broken.

e.g.,, https://thingweb.netlify.app/hands-on/intro-raspberry/

image

There are more places...

Spaces in Services missing

image

There are more..

Navigation sub navi

e.g. in Hands-on for example etc

Shall we open links in new window/tab or not?

We should be consistent..
for example Adopters don't open in new page.. playground does.. not sure what we can do. Do know that Adapteres is code from Eclipse

TD specification link

At the moment it points to dated URI, https://www.w3.org/TR/2023/REC-wot-thing-description11-20231205/
All the other don't do that.. I think we should use https://www.w3.org/TR/wot-thing-description11/ instead...

Hyphens in tools

Tools section.. Sometimes with dash between name, sometimes not
dart-wot vs dart_wot, playground without hyphen at all? Maybe also without TD ?

Draggable moving parts

Would be nice if we find a good way to drag manually the sliders...

General

I am okay with merging soon and fixing issues afterwards and once the popup...

CONTRIBUTING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still keep this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be restored

blog/tags.yml Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "old" one is without subname... I think that should be the right one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be removed

…lows sizing, implemented the feedback prompt, made the services scrollable
@egekorkan
Copy link
Member

egekorkan commented Oct 11, 2024

@danielpeintner your feedback is now implemented and deployed.

Regarding hyphens: We have reached a compromised resolution that we are happy with, which is removing the hyphen and putting a space instead.

@egekorkan
Copy link
Member

Descriptions for tools can be picked from eclipse-thingweb/.eclipsefdn#29

@danielpeintner
Copy link
Member

danielpeintner commented Oct 14, 2024

@danielpeintner your feedback is now implemented and deployed.

Regarding hyphens: We have reached a compromised resolution that we are happy with, which is removing the hyphen and putting a space instead.

Thanks 👍

In some code snippets the code seems still a bit odd and inconsistent (different indentation for examples that follow each other etc). Maybe it was there before on the old website. If there would be an autoformatter it might be even better ... anyhow.. I think it is fine as is!

BTW. the "leave us some feedback" banner takes quite a bit of space on smaller screen sizes and hides other content? Do we actually need that at all?
Anyhow, again no really strong opinion.

Edit: in the beginning the following text is shown "Liked or disliked the new website?"
Not sure, but for me this reads a bit strange. Maybe just phrase it positively... "Do you like our new website?"

…hile, links fixed, modify the community button for an adopter button, adopters section added to the read me, fixed code snipets indentation, added new description to the tools, added 2 new tools, modify the tools grid style and restored missing files
…ded the node-wot api file and removed the previous ones
…gos as well as the color, made the adopters logo faster and removed spacing, added google analytics consent banner
@egekorkan
Copy link
Member

This is now good to go. I will resolve conflicts and merge

@egekorkan egekorkan merged commit ad8f7bd into eclipse-thingweb:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants