[LIC-Base] Simplify IO operations

[HannesWell]

This PR simplifies the IO operations in the package org.eclipse.passage.lic.base.io by better leveraging Java's NIO Path API.

Some of the changes require Java-11. But since some other Plug-ins already use Java-11 as their lower bound (just like Eclipse-Platform) I assume this is OK.

[ruspl-afed]

Hi @HannesWell ! Thank you for PR.
At the moment Eclipse Passage supports Java 8 since a lot of companies are still using Java 8 (and older Eclipse Platform).
Please open a dedicated issue if you have strong arguments that Eclipse Passage need to switch to Java 11.

[HannesWell]

At the moment Eclipse Passage supports Java 8 since a lot of companies are still using Java 8 (and older Eclipse Platform). Please open a dedicated issue if you have strong arguments that Eclipse Passage need to switch to Java 11.

Understand, then I was misguided by some of the other Plug-ins that already require Java-11.
I updated this PR. It would only be a bit less code but no strong need for Java-11.

[eparovyshnaya]

Dear @HannesWell

We appreciate your effort very much.

First of all, you have found a serious bug, which is cool. Thank you!

Regarding main idea of the request: io operations are presented in Passage LIC in old-style facion for a reason: we cannot afford switchig to Java11 for Passage Core for observable future.

While products forming bundles (passage.loc, passage.fls) can indeed make use of Java11, all passage.lics must stick with Java8. We have integrations with Java8-only products, and thus must respect backward compatibility. Above this, becides Eclipse ecosystem, we build Passage LIC separately to be used in not-eclipse applications - here, too, keeping plain Java8 compatibility matters.

This means, all 8->11 porting work you've done will not pass. Sorry you wasted your resources for it.

Thank you again for spending so many time with our codebase :)

[codecov]

Codecov Report

Merging #1071 (a3b70bf) into master (4022e64) will decrease coverage by 0.03%.
The diff coverage is 96.00%.

@@             Coverage Diff              @@
##             master    #1071      +/-   ##
============================================
- Coverage     33.11%   33.07%   -0.04%     
  Complexity      346      346              
============================================
  Files          1156     1156              
  Lines         25623    25612      -11     
  Branches       1588     1587       -1     
============================================
- Hits           8485     8472      -13     
- Misses        16634    16636       +2     
  Partials        504      504              

Impacted Files	Coverage Δ
...rg/eclipse/passage/lic/base/io/FileCollection.java	85.71% <85.71%> (-9.03%)	⬇️
...c/org/eclipse/passage/lic/base/io/FileContent.java	100.00% <100.00%> (ø)
...org/eclipse/passage/lic/base/io/FileKeyKeeper.java	35.00% <100.00%> (ø)
...org/eclipse/passage/lic/base/io/PathKeyKeeper.java	62.50% <100.00%> (ø)
.../src/org/eclipse/passage/lic/base/io/Settings.java	88.00% <100.00%> (-4.86%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4022e64...a3b70bf. Read the comment docs.

[eparovyshnaya]

I updated this PR

Dear @HannesWell

Please have a look at code review concerns.

[HannesWell]

Thank you for your detailed review and elaboration. I now understand the constraints of Project passage a bit better.
I implemented your remarks accordingly. :)

The changes that require Java-11 didn't took me long, so it's not a problem that I had to revert them.

[eparovyshnaya]

@HannesWell
IO usage looks ok, there are just some code quality issues

[eparovyshnaya]

@HannesWell minor notes left.

Make also sure you've updated copyright headers of changed files according to Eclipse Project Handbook:

• place 2022 to last update position and
• mention yourself in contributors list.

[HannesWell]

Make also sure you've updated copyright headers of changed files according to Eclipse Project Handbook:

Sorry, I forgot that, thanks for the reminder. The years are updated in each file and I added myself as contributor in those files where I did more than a single line change.

[eparovyshnaya]

You did great adopting the changes for the project code quality standards!
One final touch and we are done :)

[HannesWell]

You did great adopting the changes for the project code quality standards! One final touch and we are done :)

Thanks. I applied your final remark.

[eparovyshnaya]

Thank you )

[HannesWell]

Thank you )

You are welcome and thank you for your reviews. :)