Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modifies the AWS vault implementation to update existing secrets #379

Conversation

zub4t
Copy link
Contributor

@zub4t zub4t commented Jul 21, 2024

What this PR changes/adds

This PR updates the AWS Vault implementation to match the behavior of HashiCorp Vault. Previously, the store method in the AWS Vault implementation only created new secrets. With this update, the method now supports both creating and updating secrets, aligning it with the behavior of HashiCorp Vault.

Why it does that

This update is required because the recent addition of the Secrets Manager API introduces the capability to update secrets. As a result, the AWS Vault implementation must be updated to handle secret updates in addition to secret creation.

Linked Issue(s)

Closes #373

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@ndr-brt ndr-brt self-requested a review July 22, 2024 06:48
@ndr-brt ndr-brt added the enhancement New feature or request label Jul 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.47%. Comparing base (d177a98) to head (ee5e740).
Report is 54 commits behind head on main.

Files Patch % Lines
.../eclipse/edc/vault/aws/AwsSecretsManagerVault.java 72.72% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #379      +/-   ##
============================================
+ Coverage     63.82%   65.47%   +1.65%     
- Complexity        0      113     +113     
============================================
  Files            26       28       +2     
  Lines           633      672      +39     
  Branches         30       32       +2     
============================================
+ Hits            404      440      +36     
+ Misses          222      218       -4     
- Partials          7       14       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zub4t zub4t requested a review from ndr-brt July 22, 2024 13:56
@ndr-brt
Copy link
Member

ndr-brt commented Jul 23, 2024

please fix the failing check and I will merge this

@zub4t zub4t changed the title Modifies the store method in the vault to update existing secrets ins… feat: Modifies the AWS vault implementation to update existing secrets Jul 23, 2024
@ndr-brt ndr-brt merged commit 6830f80 into eclipse-edc:main Jul 23, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Secrets Management Vault doesn't update existing secrets
3 participants