feat: Modifies the AWS vault implementation to update existing secrets (Backport) #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in this discussion |
|
just curious: was this cherry-picked or backported? |
...mmon/vault/vault-aws/src/test/java/org/eclipse/edc/vault/aws/AwsSecretsManagerVaultTest.java
Outdated
Show resolved
Hide resolved
...mmon/vault/vault-aws/src/test/java/org/eclipse/edc/vault/aws/AwsSecretsManagerVaultTest.java
Outdated
Show resolved
Hide resolved
...mmon/vault/vault-aws/src/test/java/org/eclipse/edc/vault/aws/AwsSecretsManagerVaultTest.java
Outdated
Show resolved
Hide resolved
…c/vault/aws/AwsSecretsManagerVaultTest.java Co-authored-by: Paul Latzelsperger <[email protected]>
It's cherry-pick. But since the target is an older version, I think the term backport can also be applied here 😅 |
…nts were passed in
ndr-brt
approved these changes
Aug 19, 2024
paullatzelsperger
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR updates the AWS Vault implementation to match the behavior of HashiCorp Vault. Previously, the store method in the AWS Vault implementation only created new secrets. With this update, the method now supports both creating and updating secrets, aligning it with the behavior of HashiCorp Vault.
Why it does that
This update is required because the recent addition of the Secrets Manage API introduces the capability to update secrets. As a result, the AWS Vault implementation must be updated to handle secret updates in addition to secret creation.
Further Notes
This is a backport from PR