Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature as a valid Wasm custom segment #90

Closed
wants to merge 1 commit into from
Closed

Add signature as a valid Wasm custom segment #90

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. Add signature as a valid Wasm custom segment 

    This is needed for the Wasm target, otherwise the binary file is invalid.
For other targets the extra few bytes are unnecessary, but for uniformity
I think it's better to always have them (and this align to the behaviour of
duckdb/duckdb/script/append_metadata.cmake)

Also port the cryptic comments from append_metadata.cmake script
    @carlopi
    carlopi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d7159de View commit details
    Browse the repository at this point in the history