Add signature as a valid Wasm custom segment #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the Wasm target, otherwise the binary file is invalid. For other targets the extra few bytes are unnecessary, but for uniformity I think it's better to always have them (and this align to the behaviour of duckdb/duckdb/script/append_metadata.cmake) Also port the cryptic comments from append_metadata.cmake script
samansmink
approved these changes
Oct 9, 2024
|
There was a problem in the comment style, reopened as #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the Wasm target, otherwise the binary file is invalid. For other targets the extra few bytes are unnecessary, but for uniformity I think it's better to always have them (and this align to the behaviour of
duckdb/duckdb/script/append_metadata.cmake)Also port the cryptic comments from the original
append_metadata.cmakescript.