-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureDevOpsDsc: Increase Azure DevOps API timeout and other minor fixes (fixes #5, #10, #11, #12 and #25) #28
Conversation
…' directory) and dsccommunity#11 (removing 'Examples' directory).
@johlju - Shout if you've any questions with this. Nothing too major within these changes. The integration tests ran OK locally against my Azure DevOps instance so I'd expect them to run OK when merged. Additionally, the API timeout is now 5 minutes so that should resolve the intermittent, integration failures. I might look at the SQL Server (2019) and Azure DevOps Server (2020) installs (on build server as part of integration tests) for the next PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SphenicPaul)
a discussion (no related file):
Now that we are fixing enums, can we remove these?
AzureDevOpsDsc/source/Classes/003.AzDevOpsDscResourceBase.ps1
Lines 1 to 6 in 48e919e
# This enum is re-defined here so it is recognised by 'Import-DscResource' (which won't pre/post-parse the 'using' statements) | |
#enum Ensure | |
#{ | |
# Present | |
# Absent | |
#} |
… and 'AzDevOpsDscResourceBase' classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 16 files reviewed, 1 unresolved discussion (waiting on @johlju)
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Now that we are fixing enums, can we remove these?
AzureDevOpsDsc/source/Classes/003.AzDevOpsDscResourceBase.ps1
Lines 1 to 6 in 48e919e
# This enum is re-defined here so it is recognised by 'Import-DscResource' (which won't pre/post-parse the 'using' statements) #enum Ensure #{ # Present # Absent #}
Done.
I've added some comments/properties on the three, base classes also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 16 files reviewed, 1 unresolved discussion (waiting on @johlju)
a discussion (no related file):
Previously, SphenicPaul (Paul J. Wilcox) wrote…
Done.
I've added some comments/properties on the three, base classes also.
...and also added comments/headers for the AzDevOpsProject
class/resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SphenicPaul)
Pull Request (PR) description
Includes a number of minor fixes to close some small/minor issues:
Get-AzDevOpsApiWaitTimeoutMs
to 300000 (5 minutes). Also increased related, parameter validation ranges withinTest-AzDevOpsApiTimeoutExceeded
,Wait-AzDevOpsApiResource
andWait-AzDevOpsApiOperation
functions (fixes AzDevOpsProject: Integration tests fails intermittently with timeout error #25).Classes
andExamples
directories from thebuild.yaml
so they don't get copied into the module output (fixes AzureDevOpsDsc: Built module contain folder 'Classes' #10 and AzureDevOpsDsc: Built module contain folder 'Examples' #11).'prefix.ps1' (fixes AzureDevOpsDsc: Enums should move out of prefix file #12)
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is