-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureDevOpsDsc: Enums should move out of prefix file #12
Comments
@johlju / @gaelcolas - Regarding this point, having moved the enums into their own directory (and files) and out of the See fork branch here. I'm skipping this for now but any thoughts/comments/suggestions welcome. |
Well, it seems the folder name should be the very non-intuitive I had to double-check in this repo as I know @gaelcolas made it work there: https://github.com/dsccommunity/JeaDsc/tree/master/source I learned something new today. 🙂 |
It's a Module Builder thing, but yeah I agree that it's not very intuitive
…On Thu, 28 Jan 2021, 19:50 Johan Ljunggren, ***@***.***> wrote:
Well, it seems the folder name should be the very non-intuitive Enum and
not Enums that you would expect since the other folder is Classes and not
Class. 😆
I had to double-check in this repo as I know @gaelcolas
<https://github.com/gaelcolas> made it work there:
https://github.com/dsccommunity/JeaDsc/tree/master/source
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEMANPYGQ2CPNFURU6BWVDS4GWYDANCNFSM4WQP2IEQ>
.
|
Thanks both. That resolved it. 😄 Added to PR #28. |
…es (#28) - AzureDevOpsDsc - Increased Azure DevOps, API timeout to 5 minutes to allow for busy/slow API operations (issue #25). - Updated contextual help (issue #5). - Removed `Classes` directory from being output in packaged module (issue #10). - Removed `Examples` directory from being output in packaged module (issue #11). - Moved 'Ensure' and 'RequiredAction' enums into 'Enum' directory and out of 'prefix.ps1' (issue #12).
Like 'Classes' enums should be single ps1 files with 1 enum definition per file. Compilation will put them in the main module psm1.
No needs for subfolders in enums.
AzureDevOpsDsc/source/prefix.ps1
Lines 13 to 28 in 8d43d12
As per #7 (comment).
The text was updated successfully, but these errors were encountered: