Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Bump timeout for Aspire.Hosting.Elasticsearch.Tests to 20 mins #5270

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[tests] Bump timeout for Aspire.Hosting.Elasticsearch.Tests to 20 mins #5270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de99c60
Bump timeout for Aspire.Hosting.Elasticsearch.Tests to 20 mins
radical Aug 12, 2024
5fa548c
Merge remote-tracking branch 'origin/main' into bump-test-timeouts
radical Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/helix/send-to-helix-basictests.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
<ItemGroup>
<!-- needed for Aspire.Hosting.Container.Tests -->
<HelixPreCommand Include="$(_EnvVarSetKeyword) DOCKER_BUILDKIT=1" />

<_TestRunCommandArguments Condition="'$(OS)' != 'Windows_NT'" Include="-- RunConfiguration.TestSessionTimeout=$TEST_TIMEOUT" />
<_TestRunCommandArguments Condition="'$(OS)' == 'Windows_NT'" Include="-- RunConfiguration.TestSessionTimeout=%TEST_TIMEOUT%" />
</ItemGroup>

<PropertyGroup>
Expand All @@ -21,10 +24,14 @@

<ItemGroup>
<_DefaultWorkItems Include="$(WorkItemArchiveWildCard)" />
<!-- runsettings timeout in ms, default to 10 mins -->
<_DefaultWorkItems TimeoutMs="600000" />

<_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="1200000" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be done with a runsettings file? If this is done centrally here this will be missed out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can, but you would need a copy of the .runsettings file for any project that is overriding it. I have some changes planned that would give the projects more control over their own helix run. But this should get us closer to green CI for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as long as you intend to de-centralize it later. Something like in projects would be great.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really long time. Do we know why it is taking that long?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because elasticsearch takes a few minutes to start up, and in the functional tests we are starting that up per test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what it looked like from the log. The helix agents is underpowered compared to the build machine, so it would affect it too.


<HelixWorkItem Include="@(_DefaultWorkItems -> '%(FileName)')">
<PayloadArchive>%(Identity)</PayloadArchive>
<PreCommands>$(_EnvVarSetKeyword) &quot;TEST_NAME=%(FileName)&quot;</PreCommands>
<PreCommands>$(_EnvVarSetKeyword) &quot;TEST_NAME=%(FileName)&quot; $(_ShellCommandSeparator) $(_EnvVarSetKeyword) TEST_TIMEOUT=%(TimeoutMs)</PreCommands>

<PostCommands Condition="'$(OS)' != 'Windows_NT'">cp $(_HelixLogsPath)/TestResults.trx $(_HelixLogsPath)/$(_TestNameEnvVar).trx</PostCommands>
<PostCommands Condition="'$(OS)' == 'Windows_NT'">copy &quot;$(_HelixLogsPath)\TestResults.trx&quot; &quot;$(_HelixLogsPath)\$(_TestNameEnvVar).trx&quot;</PostCommands>
Expand Down