Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Bump timeout for Aspire.Hosting.Elasticsearch.Tests to 20 mins #5270

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

radical
Copy link
Member

@radical radical commented Aug 12, 2024

Description

Contributes to #5247 .

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 12, 2024
@radical radical force-pushed the bump-test-timeouts branch from 84486c3 to de99c60 Compare August 12, 2024 21:21
@radical radical marked this pull request as ready for review August 12, 2024 21:49
@radical radical requested a review from eerhardt as a code owner August 12, 2024 21:49
<!-- runsettings timeout in ms, default to 10 mins -->
<_DefaultWorkItems TimeoutMs="600000" />

<_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="1200000" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be done with a runsettings file? If this is done centrally here this will be missed out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can, but you would need a copy of the .runsettings file for any project that is overriding it. I have some changes planned that would give the projects more control over their own helix run. But this should get us closer to green CI for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as long as you intend to de-centralize it later. Something like in projects would be great.

<!-- runsettings timeout in ms, default to 10 mins -->
<_DefaultWorkItems TimeoutMs="600000" />

<_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="1200000" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really long time. Do we know why it is taking that long?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because elasticsearch takes a few minutes to start up, and in the functional tests we are starting that up per test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what it looked like from the log. The helix agents is underpowered compared to the build machine, so it would affect it too.

@radical
Copy link
Member Author

radical commented Aug 13, 2024

/azp run

@radical radical merged commit 7378176 into dotnet:main Aug 13, 2024
11 checks passed
@radical radical deleted the bump-test-timeouts branch August 13, 2024 05:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants