-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Bump timeout for Aspire.Hosting.Elasticsearch.Tests to 20 mins #5270
Conversation
84486c3
to
de99c60
Compare
<!-- runsettings timeout in ms, default to 10 mins --> | ||
<_DefaultWorkItems TimeoutMs="600000" /> | ||
|
||
<_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="1200000" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be done with a runsettings file? If this is done centrally here this will be missed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, but you would need a copy of the .runsettings
file for any project that is overriding it. I have some changes planned that would give the projects more control over their own helix run. But this should get us closer to green CI for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, as long as you intend to de-centralize it later. Something like in projects would be great.
<!-- runsettings timeout in ms, default to 10 mins --> | ||
<_DefaultWorkItems TimeoutMs="600000" /> | ||
|
||
<_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="1200000" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really long time. Do we know why it is taking that long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because elasticsearch takes a few minutes to start up, and in the functional tests we are starting that up per test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what it looked like from the log. The helix agents is underpowered compared to the build machine, so it would affect it too.
/azp run |
Description
Contributes to #5247 .
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow