-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API updates #7
API updates #7
Conversation
…ttp API does not work on Heos-enabled AVR devices
Bumped version
Bumped `denon-client` to fix ZONE2 turning on.
Updated `denon-client` to fix ZONE2 issue
@jcharr1 do you still want to get this merged into this extension? I don't have any Denon/Marantz device anymore to actually test anything? Which is also the reason why it took me... let's check... more than three years to respond... |
@docbobo Since you don't have any devices to test yourself on anymore, I feel a little odd asking you merge this into your own repo now. I'll leave it up to you, though. I'm fine with either way. |
Fair enough. But I had some issues reported recently, and I don't want to leave everyone hanging any longer 😉 Plus, there also seem to be security issues. What about this: I'll try to merge this into some separate branch first, spend some minor time on it, than push a build to docker that you can verify. Maybe we can move this into the roon extension manager repo afterwards. |
Sounds good. 👍🏻 |
Okay, can you check if The docker image itself is based on If you are interested the code changes are in |
Seems to be working just fine on my Synology NAS. 👍🏻 |
Awesome. That makes it already two, I guess. I'll probably go on and merge #10 then - I was mostly looking for some more general breakages. |
A few questions:
|
|
Awesome on both ends. Just added you, you should've an invite. If something has to change, let's try to do that via a PR anyway, I would suggest. Unless it's something super urgent - in that case cowboy mode is also fine. |
Will close this PR now. Email is in the logs 😉 |
-api update via @dfuchslin
-updated node-roon-api dependency to fix
this.moo.close is not a function
error on closing Roon.-added Dockerfile
Fixes #6.