Update extension to be ready for 2025 and beyond #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Denon http API does not work on Heos-enabled AVR devices.
Fixes "this.moo.close is not a function" error.
Bumped version
Bumped `denon-client` to fix ZONE2 turning on.
docbobo
force-pushed
the
docbobo/bring-this-to-2025
branch
from
4a509e9 to
479eccc
Compare
docbobo
force-pushed
the
docbobo/bring-this-to-2025
branch
from
2903290 to
8b2a40d
Compare
Closed
docbobo
force-pushed
the
docbobo/bring-this-to-2025
branch
from
8b2a40d to
b497488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this extension needs some love. Unfortunately, I don't have a Denon receiver anymore, so I am not able to test any of this. But then again, this PR mostly contains changes not made by me. Instead it's been cherry-picking most of the changes from #7.
I believe it also fixes #6 and #8, maybe #9.
While this PR is being worked on, the changes are available as docker image from
docker.io/docbobo/roon-extension-denon:latest