Ag/notion source update #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/notion/helpers/client.py
Outdated
| @@ -151,3 +151,14 @@ def search( | |||
| next_cursor = response.get("next_cursor") | |||
| has_more = next_cursor is not None | |||
| start_cursor = next_cursor | |||
|
|
|||
| def get_database(self, database_id: str) -> Dict[str, Any]: | |||
There was a problem hiding this comment.
linter failed. change Dict[str, Any] to Any.
There was a problem hiding this comment.
the rest looks good, well done))
There was a problem hiding this comment.
don't forget to edit docstring
There was a problem hiding this comment.
Changes done. Please see.
There was a problem hiding this comment.
PR passed the checks @AstrakhantsevaAA 👍 please review. Thanks
AstrakhantsevaAA
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
verified source)Relevant issue
issue # 241
More PR info
This PR addresses the issue where the Notion pipeline expects both id and use_name when fetching data from custom databases. Previously, omitting use_name would lead to a KeyError.
Changes made:
If use_name is not provided, the pipeline will now automatically retrieve it from Notion. For example, if the input is:
This not only prevents the aforementioned error but also improves the user experience, making the pipeline a bit more user-friendly and intuitive.
Users can also give input as:
Please review and let me know if there are any additional changes needed.