Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] handle KeyError for Notion source #241

Closed
AstrakhantsevaAA opened this issue Aug 14, 2023 — with Slack · 2 comments
Closed

[improve] handle KeyError for Notion source #241

AstrakhantsevaAA opened this issue Aug 14, 2023 — with Slack · 2 comments
Assignees

Comments

Copy link
Collaborator

Currently, Notion pipeline fetches data from databases. If we wish to fetch data from custom databases, it requires input like:

selected_database_ids = [{"id": "dfgs", "use_name": "ddf"}] 

However, if we omit the use_name, it results in a KeyError.

TODO:
If the use_name isn’t supplied, the code will automatically fetch it from Notion. For instance, you can input:

selected_database_ids = [{"id": "fllff"}]

And the system will retrieve the corresponding use_name directly from Notion. It’s a minor adjustment, but I believe it eases user experience.( for me it did)
Before this change, only providing a database ID without the use_name would lead to an error. This modification should make the process more user-friendly.

@dat-a-man
Copy link
Collaborator

PR created : #242

@dat-a-man dat-a-man self-assigned this Aug 14, 2023
@rudolfix
Copy link
Contributor

we should convert Notion into a source that is like our sql_database or incoming Mongo/Airtable where you select databases, then tables and configure them for sync...

@rudolfix rudolfix closed this as completed Oct 4, 2023
@github-project-automation github-project-automation bot moved this from Planned to Ready for Deployment in Verified Sources Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Deployment
Development

No branches or pull requests

3 participants