Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 37 route net gateway support #39

Merged

Conversation

LePhanFF
Copy link
Contributor

No description provided.

@LePhanFF
Copy link
Contributor Author

`ubuntu@ip-10-1-8-103:~/terraform-provider-pritunl$ sudo make test
tf_pritunl_acc_test
e87685df512dc91f1c3916835deb4c563a36d0cd394d7ea4f26e77e20f63b6df
sleep 40
./tools/wait-for-it.sh localhost:27017 -- echo "mongodb is up"
wait-for-it.sh: waiting 15 seconds for localhost:27017
wait-for-it.sh: localhost:27017 is available after 0 seconds
mongodb is up

enables an api access for the pritunl user, updates an api token and secret

MongoDB shell version v4.4.15
connecting to: mongodb://127.0.0.1:27017/pritunl?compressors=disabled&gssapiServiceName=mongodb
Implicit session: session { "id" : UUID("74599192-c325-49ae-bfd5-cc22e4ac0730") }
MongoDB server version: 4.4.15
{ "acknowledged" : true, "matchedCount" : 1, "modifiedCount" : 1 }
bye
TF_ACC=1
PRITUNL_URL="https://localhost/"
PRITUNL_INSECURE="true"
PRITUNL_TOKEN=tfacctest_token
PRITUNL_SECRET=tfacctest_secret
go test -v -cover -count 1 ./internal/provider
=== RUN TestDataSourceHost
=== PAUSE TestDataSourceHost
=== RUN TestAccOrganization_basic
=== PAUSE TestAccOrganization_basic
=== RUN TestGetServer_basic
--- PASS: TestGetServer_basic (5.09s)
=== RUN TestGetServer_with_attached_organization
--- PASS: TestGetServer_with_attached_organization (4.17s)
=== RUN TestGetServer_with_a_few_attached_organizations
--- PASS: TestGetServer_with_a_few_attached_organizations (7.61s)
=== RUN TestGetServer_with_attached_route
--- PASS: TestGetServer_with_attached_route (6.18s)
=== RUN TestGetServer_with_a_few_attached_routes
--- PASS: TestGetServer_with_a_few_attached_routes (5.44s)
=== RUN TestGetServer_with_invalid_route
--- PASS: TestGetServer_with_invalid_route (1.46s)
=== RUN TestCreateServer_with_invalid_network
--- PASS: TestCreateServer_with_invalid_network (1.50s)
=== RUN TestCreateServer_with_unsupported_network
--- PASS: TestCreateServer_with_unsupported_network (3.90s)
=== RUN TestCreateServer_with_invalid_bind_address
--- PASS: TestCreateServer_with_invalid_bind_address (3.99s)
=== RUN TestGetServer_with_default_host
--- PASS: TestGetServer_with_default_host (3.32s)
=== RUN TestGetServer_without_hosts
--- PASS: TestGetServer_without_hosts (4.91s)
=== RUN TestAccUser_basic
=== PAUSE TestAccUser_basic
=== CONT TestDataSourceHost
=== CONT TestAccUser_basic
=== CONT TestAccOrganization_basic
--- PASS: TestDataSourceHost (4.11s)
--- PASS: TestAccOrganization_basic (8.24s)
--- PASS: TestAccUser_basic (12.60s)
PASS
coverage: 62.8% of statements
ok github.com/disc/terraform-provider-pritunl/internal/provider 60.208s coverage: 62.8% of statements
tf_pritunl_acc_test

`

The test passed

and the attribute net_gateway was created

image

This was referenced Aug 24, 2023
@LePhanFF LePhanFF changed the title Feature/issue 37 route net gateway support goodtest Feature/issue 37 route net gateway support Aug 25, 2023
@disc
Copy link
Owner

disc commented Aug 26, 2023

Hey @LePhanFF, thanks for your contribution!

@disc disc self-requested a review August 26, 2023 13:17
@disc
Copy link
Owner

disc commented Aug 26, 2023

@LePhanFF I can't merge your MR without green tests, but i see 0 checks after you change the branch. Can you try to create a new pull request with "green" tests?

Copy link
Owner

@disc disc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests workflow should be passed successfully, no "checks" were executed in this PR

@LePhanFF
Copy link
Contributor Author

LePhanFF commented Aug 26, 2023

Hello @disc
It appears that the green checks are awaiting for your approval to run since I am merging from a forked repository. My green tests have passed at in my own repo at

LePhanFF#4

I believe if you approve the workflow it should be good to go. If not, you might have to add me to be a repo contributor for me to create a branch with my changes.

Thanks,

Le

screen of passed tests:
image

@disc disc merged commit 58108f6 into disc:master Aug 26, 2023
3 checks passed
@LePhanFF
Copy link
Contributor Author

@disc Thank you so much. Let me know when you can release the next version for this, any estimated ETA would be great, I have a bug in pritunl server eagerly trying to fix with setting up net gateway route.

@disc
Copy link
Owner

disc commented Aug 27, 2023

@LePhanFF new version has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants