adding NetGateway Support #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disc
requested changes
Aug 17, 2023
| @@ -41,6 +41,9 @@ func ConvertMapToRoute(data map[string]interface{}) Route { | |||
| if v, ok := data["nat"]; ok { | |||
| route.Nat = v.(bool) | |||
| } | |||
| if v, ok := data["net_gateway"]; ok { | |||
| route.NetGateway = v.(bool) | |||
There was a problem hiding this comment.
I see the setter of the NetGateway property but didn't see any place where you use this property in the provider. Do you need just to store this property in the state or I miss something?
There was a problem hiding this comment.
We need to create net gateway route, would this change set the route type when it invokes the api to create the route?
There was a problem hiding this comment.
I found some places where it could be used, would these changes work, please suggest
|
replaced with #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.