Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fake icrc_metadata implementation for demo #382

Merged
merged 2 commits into from
Dec 25, 2024
Merged

feat: fake icrc_metadata implementation for demo #382

merged 2 commits into from
Dec 25, 2024
+2,208 −0

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Dec 24, 2024 •
edited
Loading

Motivation

This PR ejects the Juno Satellite and adds a fake icrc_metadata endpoints that can be used to either run locally the E2E test provided in #381 or just test manually the demo function #380.

@peterpeterparker peterpeterparker requested a review from a team as a code owner December 24, 2024 08:41
@peterpeterparker peterpeterparker mentioned this pull request Dec 24, 2024
Merged
AntonioVentilii
AntonioVentilii approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am presuming that the candid files of the satellite comes directly from Juno, no need to review, right? In that case, approved

@peterpeterparker
Copy link
Member Author

candid files of the satellite comes directly from Juno

Exactly. The satellite.did file contains the standard behavior of a Juno Satellite and the satellite_extended.did file contains the custom code.

@peterpeterparker peterpeterparker merged commit 01e6e11 into main Dec 25, 2024
10 checks passed
@peterpeterparker peterpeterparker deleted the feat/fake-metadata-for-demo-canister branch December 25, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii AntonioVentilii AntonioVentilii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @AntonioVentilii