e2e: skipped test for build consent message #381
Merged
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
approved these changes
Dec 24, 2024
| }: { | ||
| walletUserId: string; | ||
| partyUserId: string; | ||
| tokenSymbol: 'ICP' | 'TKN'; |
There was a problem hiding this comment.
Not really sure if it will be expanded or used more than here (and in the other file modified), but does it make sense to create a mock type for 'ICP' | 'TKN'?
There was a problem hiding this comment.
It probably won't expand soon because the Juno Docker used for E2E testing supports only ICP; no other ledger is deployed within the container. TKN is the custom test. Therefore, I would suggest we skip this for now?
There was a problem hiding this comment.
Note: I merge the PR but, we can create the type in another PR if you think it's worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I don't really want to automate the test of the "Build consent message" in the CI because it would requires building the canister of #382 in the pipeline which would require some tooling and time but, it's still handy to have a test to run locally. That's why this PR add such an E2E test.
Changes