clippy

.github/workflows/e2e.yml

@@ -11,7 +11,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ macos-latest, ubuntu-latest ]
-        rust: [ '1.65.0' ]
+        rust: [ '1.71.1' ]
         dfx: [ '0.8.4', '0.9.2', '0.10.1', '0.11.1' ]
 
     steps:

.github/workflows/fmt.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        rust: [ '1.65.0' ]
+        rust: [ 1.71.1' ]
         os: [ ubuntu-latest ]
 
     steps:

.github/workflows/ic-ref.yml

@@ -17,7 +17,7 @@ jobs:
             ic-hs-ref: "3d71032e"
             wallet-tag: "20230308"
             os: ubuntu-latest
-            rust: "1.65.0"
+            rust: "1.71.1"
 
     steps:
       - uses: actions/setup-node@v3

.github/workflows/lint.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        rust: ["1.65.0"]
+        rust: ["1.71.1"]
         os: [ubuntu-latest]
 
     steps:

.github/workflows/release.yml

@@ -16,12 +16,12 @@ jobs:
             name: linux
             binary_path: target/x86_64-unknown-linux-musl/release
             binary_files: icx
-            rust: '1.65.0'
+            rust: '1.71.1'
           - os: macos-latest
             name: macos
             binary_path: target/release
             binary_files: icx
-            rust: '1.65.0'
+            rust: '1.71.1'
     steps:
     - uses: actions/checkout@master
 

.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        rust: ["1.65.0"]
+        rust: ["1.71.1"]
         os: [ubuntu-latest, macos-latest, windows-latest]
 
     steps:

Cargo.toml

@@ -14,7 +14,7 @@ version = "0.25.0"
 authors = ["DFINITY Stiftung <[email protected]>"]
 edition = "2021"
 repository = "https://github.com/dfinity/agent-rs"
-rust-version = "1.65.0"
+rust-version = "1.71.1"
 license = "Apache-2.0"
 
 [workspace.dependencies]

ic-agent/src/identity/basic.rs

@@ -40,7 +40,7 @@ impl BasicIdentity {
             .collect::<Result<Vec<u8>, std::io::Error>>()?;
 
         Ok(BasicIdentity::from_key_pair(Ed25519KeyPair::from_pkcs8(
-            pem::parse(&bytes)?.contents(),
+            pem::parse(bytes)?.contents(),
         )?))
     }
 

ic-utils/src/call/expiry.rs

@@ -5,10 +5,11 @@ use time::OffsetDateTime;
 
 /// An expiry value. Either not specified (the default), a delay relative to the time the
 /// call is made, or a specific date time.
-#[derive(Clone, Debug, Ord, PartialOrd, Eq, PartialEq)]
+#[derive(Clone, Debug, Ord, PartialOrd, Eq, PartialEq, Default)]
 pub enum Expiry {
     /// Unspecified. Will not try to override the Agent's value, which might itself have
     /// its own default value.
+    #[default]
     Unspecified,
 
     /// A duration that will be added to the system time when the call is made.
@@ -65,9 +66,3 @@ impl From<OffsetDateTime> for Expiry {
         Self::DateTime(dt)
     }
 }
-
-impl Default for Expiry {
-    fn default() -> Self {
-        Expiry::Unspecified
-    }
-}