Merge branch 'main' into severin/update-rust

.github/workflows/conventional-commits.yml

@@ -1,6 +1,6 @@
 name: Check PR title
 on:
-  pull_request_target:
+  pull_request:
     types:
       - opened
       - reopened
@@ -9,13 +9,22 @@ on:
 
 jobs:
   check:
+    name: conventional-pr-title:required
     runs-on: ubuntu-latest
     steps:
-      - uses: dfinity/[email protected]
-        with:
-          success-state: Title follows the specification.
-          failure-state: Title does not follow the specification.
-          context-name: conventional-pr-title
-          preset: conventional-changelog-angular@latest
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        # Conventional commit patterns:
+        #   verb: description
+        #   verb!: description of breaking change
+        #   verb(scope): Description of change to $scope
+        #   verb(scope)!: Description of breaking change to $scope
+        # verb: feat, fix, ...
+        # scope: refers to the part of code being changed.  E.g. " (accounts)" or " (accounts,canisters)"
+        # !: Indicates that the PR contains a breaking change.
+      - run: |
+          if [[ "${{ github.event.pull_request.title }}" =~ ^(feat|fix|chore|build|ci|docs|style|refactor|perf|test)(\([-a-zA-Z0-9,]+\))?\!?\: ]]; then
+              echo pass
+          else
+              echo "PR title does not match conventions"
+              echo "PR title: ${{ github.event.pull_request.title }}"
+              exit 1
+          fi

.github/workflows/ic-ref.yml

@@ -67,7 +67,7 @@ jobs:
           export IC_REF_PORT=$(cat $HOME/ic_ref_port)
           export IC_UNIVERSAL_CANISTER_PATH=$HOME/canister.wasm
           export IC_WALLET_CANISTER_PATH=$HOME/wallet.wasm
-          cd main/ref-tests
+          cd main
           cargo test --all-features -- --ignored
           killall ic-ref
         env:

.github/workflows/lint.yml

@@ -8,8 +8,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        rust: [ '1.65.0' ]
-        os: [ ubuntu-latest ]
+        rust: ["1.65.0"]
+        os: [ubuntu-latest]
 
     steps:
       - uses: actions/checkout@v2
@@ -27,10 +27,13 @@ jobs:
           rustup update ${{ matrix.rust }} --no-self-update
           rustup component add clippy
           rustup default ${{ matrix.rust }}
+          rustup target add wasm32-unknown-unknown
       - name: Run Lint
         run: cargo clippy --verbose --tests --benches -- -D clippy::all
         env:
           RUST_BACKTRACE: 1
+      - name: Run Lint (WASM)
+        run: CARGO_TARGET_DIR=target/wasm cargo clippy --target wasm32-unknown-unknown -p ic-agent --features wasm-bindgen -p ic-utils --verbose -- -D clippy::all
   aggregate:
     name: lint:required
     runs-on: ubuntu-latest

.github/workflows/test.yml

@@ -11,8 +11,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        rust: [ '1.65.0' ]
-        os: [ ubuntu-latest, macos-latest, windows-latest ]
+        rust: ["1.65.0"]
+        os: [ubuntu-latest, macos-latest, windows-latest]
 
     steps:
       - uses: actions/checkout@v2
@@ -29,6 +29,12 @@ jobs:
         run: |
           rustup update ${{ matrix.rust }} --no-self-update
           rustup default ${{ matrix.rust }}
+          rustup target add wasm32-unknown-unknown
+
+      - name: Install wasm-pack
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        run: |
+          curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
 
       - name: Run Tests
         shell: bash
@@ -43,6 +49,11 @@ jobs:
         env:
           RUST_BACKTRACE: 1
 
+      - name: Run Tests (WASM)
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        run: |
+          CARGO_TARGET_DIR=../target/wasm wasm-pack test --chrome --headless ic-agent --features wasm-bindgen
+
       - name: Purge for OSX
         if: matrix.os == 'macos-latest'
         run: |

CHANGELOG.md

@@ -6,7 +6,34 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+##  Unreleased
+
+## [0.25.0] - 2023-07-05
+
+* Breaking Change: builders are now owning-style rather than borrowing-style; with_arg takes an owned Vec rather than a borrowed Vec
+* Breaking Change: Identity::sign takes &EnvelopeContent rather than the request ID.
+* Bump Candid crate to 0.9.0
+
+## [0.24.0] - 2023-05-19
+
+* fix: Adjust the default polling parameters to provide better UX. Remove the `CouldNotReadRootKey` error and panic on poisoned mutex.
+* chore: remove deprecated code and fix style
+* Breaking Change: removing the PasswordManager
+* Breaking Change: Enum variant `AgentError::ReplicaError` is now a tuple struct containing `RejectResponse`.
+* Handling rejected update calls where status code is 200. See IC-1462
+* Reject code type is changed from `u64` to enum `RejectCode`.
+
+* Support WASM targets in the browser via `wasm-bindgen`. Feature `wasm-bindgen` required.
+* Do not send `certificate_version` on HTTP Update requests
+* Update `certificate_version` to `u16` instead of `u128`, fixes an issue where the asset canister always responds with v1 response verification
+
+### ic-certification
+
+* Breaking change: Content and path storage has been changed from a `Cow<[u8]>` to a user-provided `T: AsRef<u8>`, removing the lifetime from various types.
+
+### icx-cert
+
+* Fixed issue where a missing request header caused the canister to not respond with an `ic-certificate` header.
 
 ## [0.23.2] - 2023-04-21