Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Dockerfile changes (WORKDIR, user, cleanup) #1101

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Minor Dockerfile changes (WORKDIR, user, cleanup) #1101

wants to merge 6 commits into from

Conversation

ryan-mcneil
Copy link
Contributor

@ryan-mcneil ryan-mcneil commented Apr 18, 2024 •
edited
Loading

Description

Made a few minor changes in the dockerfile, so that less changes are introduced later:

  • Update base image syntax to match Rails standard
  • update WORKDIR to /app to match vets-api
  • update useradd/groupadd commands to more closely align with Rails standard
  • remove unnecessary whoami

Original issue(s)

department-of-veterans-affairs/va.gov-team#79340

Testing done

  • specs ran properly locally with make build then make ci

Screenshots

Acceptance criteria

  • [ ]

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@ryan-mcneil ryan-mcneil requested a review from a team as a code owner April 18, 2024 18:46
@ryan-mcneil ryan-mcneil marked this pull request as draft April 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryan-mcneil