CSS Library: style and image path updates for alert and action link modules

[jamigibbs]

Chromatic

https://3397-action-link-alert-updates--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

I did some additional testing in vets-website with action link and alert classes and I noticed a few style issues with alert so this PR will fix that:

related

• Formation Deprecation - Core import swap vets-design-system-documentation#3397
• CSS Library: replace FA icons for action link and alert classes #1371

QA Checklist

• Component maintains 1:1 parity with design mocks
• Text is consistent with what's been provided in the mocks
• Component behaves as expected across breakpoints
• Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
• Designer has signed off on changes (if applicable. If not applicable provide reason why)
• Tab order and focus state work as expected
• Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
• New components are covered by e2e tests; updates to existing components are covered by existing test suite
• Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

• QA checklist has been completed
• Screenshots have been attached that cover desktop and mobile screens

Definition of done

• Documentation has been updated, if applicable
• A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

[powellkerry]

Changes look good. This probably isn't related but it looks like the lock icon isn't aligned correctly.

[jamigibbs]

Changes look good. This probably isn't related but it looks like the lock icon isn't aligned correctly.

@powellkerry Interesting. That's for the web component which these updates shouldn't be affecting but we should take a closer look at that. I see it in production Storybook too. I'll write up a follow-up ticket!

EDIT: Here is the ticket:

• va-alert lock icon not aligned in the same way as the other icons vets-design-system-documentation#3440