Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Library: remove the /alerts image path #1381

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Oct 25, 2024

Chromatic

https://{{head.ref}}--65a6e2ed2314f7b8f98609d8.chromatic.com

I rushed a little with this previous PR and forgot to remove the /alerts image path for the old Alert module. 🤦🏻‍♀️ The images will load from the base /img folder like where they are here in content-build.

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@jamigibbs jamigibbs marked this pull request as ready for review October 25, 2024 15:26
@jamigibbs jamigibbs requested a review from a team as a code owner October 25, 2024 15:26
@jamigibbs jamigibbs merged commit 8857ee7 into main Oct 25, 2024
8 checks passed
@jamigibbs jamigibbs deleted the 3397-action-link-alert-updates branch October 25, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants