Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add render blocking errors to Chart #2255

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

jnumainville
Copy link
Contributor

@jnumainville jnumainville commented Oct 15, 2024

Adds new events that enable render-blocking overlays to the chart.
The current error pop-up is not sufficient because it still allows the chart to render. This is problematic in the case of webgl because disabling webgl means we don't want the chart rendering at all in case the computer can't handle it.

This is specifically built with deephaven/deephaven-plugins#612 in mind.

Here is an example of the pop-up as implemented in deephaven/deephaven-plugins#934
image

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving as comments instead of request changes since I'll be out tomorrow and Friday

packages/chart/src/Chart.tsx Outdated Show resolved Hide resolved
packages/chart/src/Chart.tsx Outdated Show resolved Hide resolved
packages/chart/src/Chart.tsx Outdated Show resolved Hide resolved
packages/chart/src/ChartModel.ts Show resolved Hide resolved
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 46.57%. Comparing base (229adf0) to head (5732603).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/chart/src/Chart.tsx 0.00% 28 Missing ⚠️
packages/chart/src/ChartModel.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2255    +/-   ##
========================================
  Coverage   46.57%   46.57%            
========================================
  Files         698      698            
  Lines       38767    38790    +23     
  Branches     9866     9685   -181     
========================================
+ Hits        18054    18065    +11     
- Misses      20702    20714    +12     
  Partials       11       11            
Flag Coverage Δ
unit 46.57% <5.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnumainville jnumainville merged commit 74a5cb7 into deephaven:main Oct 22, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants