fix: dx
now respects the webgl flag
#934
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #612
The current implementation has the following behavior, although note that this will not work fully until deephaven/web-client-ui#2255 is merged
scattergl
->scatter
) and replaced again if reenabled (scatter
->scattergl
)scatter3d
orscattermapbox
) the prompt in the image below will appear. Once accepted, the acceptance persists for this specific chart, even if webgl is toggled again.Note that disabling and reenabling through the settings without clicking Continue doesn't count as an acceptance, so if the prompt appears, the setting is enabled, then the setting is disabled again, the prompt will still appear.