Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dx now respects the webgl flag #934

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jnumainville
Copy link
Collaborator

@jnumainville jnumainville commented Oct 15, 2024

Fixes #612

The current implementation has the following behavior, although note that this will not work fully until deephaven/web-client-ui#2255 is merged

  1. If webgl is enabled, nothing happens
  2. If webgl is disabled and the webgl chart trace type can be replaced, it will be (such as scattergl -> scatter) and replaced again if reenabled (scatter -> scattergl)
  3. If webgl is disabled and the webgl chart trace can't be replaced (such as scatter3d or scattermapbox) the prompt in the image below will appear. Once accepted, the acceptance persists for this specific chart, even if webgl is toggled again.
    Note that disabling and reenabling through the settings without clicking Continue doesn't count as an acceptance, so if the prompt appears, the setting is enabled, then the setting is disabled again, the prompt will still appear.

image

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need package bump but looks okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deephaven express should respect the disable webGL flag
2 participants