Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system gtest and benchmark in Pixi tasks #1905

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 20, 2025

  • Use system googletest and googlebenchmark within Pixi environments.
  • Update googletest and googlebenchmark fetching to the latest versions
  • Upgrade all other dependencies in Pixi environments by running pixi upgrade.
  • Replace deprecated depends_on with depends-on in pixi.toml

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.16.0 milestone Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.55%. Comparing base (c18c48a) to head (1da7345).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1905   +/-   ##
=======================================
  Coverage   61.54%   61.55%           
=======================================
  Files         490      490           
  Lines       46013    46013           
=======================================
+ Hits        28320    28322    +2     
+ Misses      17693    17691    -2     

see 1 file with indirect coverage changes

@jslee02 jslee02 merged commit 97752e1 into main Jan 21, 2025
28 checks passed
@jslee02 jslee02 deleted the use_system_gtest_and_benchmark branch January 21, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant