Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy Dialect: Dependencies: Use sqlalchemy-cratedb>=0.37 #128

Merged
merged 1 commit into from
Jun 13, 2024
Merged

SQLAlchemy Dialect: Dependencies: Use sqlalchemy-cratedb>=0.37 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/.idea
/.venv*
/dist
/doc/_build
/tmp
/var
.DS_Store
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Changelog

in progress
===========
- SQLAlchemy Dialect: Dependencies: Use `sqlalchemy-cratedb>=0.37.0`
This includes the fix to the `get_table_names()` reflection method.

2024-06-11 v0.3.0
=================
Expand Down
1 change: 0 additions & 1 deletion doc/backlog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ Iteration +1
************
Iteration +2
************
- [o] Fix ``cratedb_toolkit.sqlalchemy.patch_inspector()`` re. reflection of ``?schema=`` URL parameter
- [o] Fix ``crate.client.sqlalchemy.dialect.DateTime`` re. ``TimezoneUnawareException``
- [o] Support InfluxDB 1.x and 3.x
- [o] Add Docker Compose file for auxiliary services
Expand Down
4 changes: 0 additions & 4 deletions influxio/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ def dataframe_to_sql(
pbar.register()

if dburi.startswith("crate"):
# TODO: Submit patch to upstream `crate-python`. This is another proof that something is wrong.
from cratedb_toolkit.sqlalchemy import patch_inspector

patch_inspector()

# Use performance INSERT method.
try:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ dependencies = [
"pandas<2.3",
"psycopg2-binary<3",
"pueblo>=0.0.7",
"sqlalchemy-cratedb",
"sqlalchemy-cratedb>=0.37,<1",
"SQLAlchemy-Utils<0.42",
"yarl<2",
]
Expand Down