Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy Dialect: Dependencies: Use sqlalchemy-cratedb>=0.37 #128

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 13, 2024

About

This includes the fix to the get_table_names() reflection method, so it is no longer applicable to apply the monkeypatch from CrateDB Toolkit.

Details

Needed to unblock another downstream patch.

This includes the fix to the `get_table_names()` reflection method.
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.62%. Comparing base (e269b61) to head (26fe7b7).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   79.68%   79.62%   -0.07%     
==========================================
  Files          12       12              
  Lines         640      638       -2     
==========================================
- Hits          510      508       -2     
  Misses        130      130              
Flag Coverage Δ
unittests 79.62% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review June 13, 2024 16:42
@amotl amotl merged commit 8e262ff into main Jun 13, 2024
9 checks passed
@amotl amotl deleted the amo/sqlalchemy-no-patch-inspector branch June 13, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant