Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(I18N) Chinese Simplified Translation Update #471

Merged
merged 1 commit into from
Oct 25, 2023
Merged

(I18N) Chinese Simplified Translation Update #471

merged 1 commit into from
Oct 25, 2023

Conversation

yangyangdaji
Copy link

@yangyangdaji yangyangdaji commented Oct 20, 2023

translation changes

  • Translate Invert Bookmarks into 反转书签 and add comment (But my recommend is to translate it as 反向标注书签)
  • Debug日志 > 调试日志
  • 关闭当前 > 关闭当前文件
  • 性质 > 属性
  • Change 确定 into OK in update dialog

optional changes

  • ̶书签̶ ̶ ̶>̶ ̶̶标签̶ ̶ ̶(̶N̶e̶e̶d̶ ̶t̶o̶ ̶o̶n̶ ̶t̶h̶e̶ ̶s̶a̶m̶e̶ ̶p̶a̶g̶e̶)̶
  • T̶r̶a̶n̶s̶l̶a̶t̶e̶ ̶̶O̶p̶e̶n̶̶ ̶i̶n̶t̶o̶ ̶̶打开 i̶n̶
    <source>Click the &quot;Open&quot; button to apply the update</source>
    <translation>点击“Open”按钮开始应用更新</translation>
  • Maybe a lot more

Signed-off-by: yangyangdaji [email protected]

@yangyangdaji
Copy link
Author

yangyangdaji commented Oct 20, 2023

@dail8859 This PR will wait for 7 days , Waiting for review by others translator

@yangyangdaji yangyangdaji changed the title (I18N) Chinese Simplified Translation Reviewer and Update (I18N) Chinese Simplified Translation Review and Update Oct 20, 2023
@dail8859
Copy link
Owner

@yangyangdaji No problem at all. Just let me know when you are ready!

@yangyangdaji
Copy link
Author

/review @inkydragon @zhongqingsong @KangLin

@yangyangdaji
Copy link
Author

<translation>点击“确定”按钮开始安装更新</translation>
</message>
<message>
<location filename="../src/QSimpleUpdater/src/Downloader.cpp" line="212"/>
<source>In order to install the update, you may need to quit the application.</source>
<translation>为了安装更新,你可能需要退出已打开的程序。</translation>
</message>
<message>
<location filename="../src/QSimpleUpdater/src/Downloader.cpp" line="216"/>
<source>In order to install the update, you may need to quit the application. This is a mandatory update, exiting now will close the application</source>
<translation>为了安装更新,你可能需要退出已打开的程序。这是一个强制更新,现在退出将关闭应用程序</translation>
</message>
<message>
<location filename="../src/QSimpleUpdater/src/Downloader.cpp" line="235"/>
<source>Click the &quot;Open&quot; button to apply the update</source>
<translation>点击“Open”按钮开始应用更新</translation>

Translate Open into 打开 in this case
Does anybody have a suggestion for that?

@inkydragon
Copy link
Contributor

Translate Open into 打开 in this case
Does anybody have a suggestion for that?

Just keep it consistent with the buttons in the actual UI.
Keep use english if the button is not translated.

(negative example) The update dialog for older versions like:
image

@yangyangdaji
Copy link
Author

yangyangdaji commented Oct 23, 2023

(negative example) The update dialog for older versions like: image

oh I've got it

@yangyangdaji
Copy link
Author

yangyangdaji commented Oct 23, 2023

@inkydragon I changed the 确定 to OK in update dialog
Now how does this PR look, are you satisfied?

@yangyangdaji
Copy link
Author

yangyangdaji commented Oct 24, 2023

Ready to go , Waiting for Review again

@yangyangdaji yangyangdaji requested a review from KangLin October 24, 2023 09:00
Copy link
Contributor

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangyangdaji yangyangdaji changed the title (I18N) Chinese Simplified Translation Review and Update (I18N) Chinese Simplified Translation Update Oct 25, 2023
@yangyangdaji
Copy link
Author

@dail8859 This PR has been approved to wait for merging

Translate Invert Bookmarks into 反转书签
Debug日志 > 调试日志
关闭当前 > 关闭当前文件
性质 > 属性
Change 确定 into OK in update dialog

Signed-off-by: yangyangdaji <[email protected]>
Reviewed-by: woclass <[email protected]>
Reviewed-by: Kang Lin <[email protected]>
@dail8859 dail8859 merged commit 45437eb into dail8859:master Oct 25, 2023
12 checks passed
@dail8859
Copy link
Owner

Thanks so much everyone!

@yangyangdaji yangyangdaji deleted the fix-my-mistakes branch October 25, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants