Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ArgoCD custom health status snippet #673

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update ArgoCD custom health status snippet #673

merged 1 commit into from
Jan 12, 2024

Conversation

nimjor
Copy link
Contributor

@nimjor nimjor commented Jan 11, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jan 11, 2024 •
edited
Loading

✅ Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit e9b8b3f
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/65a05a689ab7bc0008ff7c1d
😎 Deploy Preview https://deploy-preview-673--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🟢 up 9 from production)
Accessibility: 88 (🔴 down 3 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@haarchri haarchri requested a review from plumbis January 11, 2024 21:35
@plumbis plumbis merged commit 7238882 into crossplane:master Jan 12, 2024
6 of 7 checks passed
@spalberg
Copy link

This does not cover ProviderConfig which can have status like { users: 1 } or simply {}.

@haarchri
Copy link
Contributor

@spalberg can you Open a followup PR ?

Thanks

@illrill illrill mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plumbis plumbis plumbis approved these changes

@haarchri haarchri haarchri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nimjor @spalberg @haarchri @plumbis