Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid inequality operator in ArgoCD custom health for ProviderConfig #687

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

illrill
Copy link
Contributor

@illrill illrill commented Jan 29, 2024

Fixes mistake by #673. In Lua, the inequality operator is ~= not !=. This caused an ArgoCD ComparisonError and sync failure.

error setting app health: failed to get resource health for "ProviderConfig" with name "azure" in namespace "": <string> line:27(column:56) near '!': Invalid token

Signed-off-by: Richard Johansson <[email protected]>
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit b999b45
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/65b7e084c37b6f0008030a33
😎 Deploy Preview https://deploy-preview-687--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 4 from production)
Accessibility: 88 (🔴 down 3 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@plumbis plumbis merged commit 05874e0 into crossplane:master Jan 29, 2024
5 checks passed
@denzhel
Copy link

denzhel commented Jan 30, 2024

Damn you're fast ... I was having this issue yesterday and I couldn't figure out what is the problem.
Refreshed the page and noticed that I had the ! missing .. what are the odds that they fixed it that quick ..
Thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants