Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show splashscreen before sending app to background #878

Closed
wants to merge 1 commit into from

Commits on Jul 20, 2023

  1. fix: Don't show splashscreen before sending app to background

    When implementing the Lock screen we tried to call the
    `showSplashScreen()` method before the app being sent to background
    
    This would prevent the app's content to be briefly displayed when going
    back to the app in the scenario where the Lock screen would need to be
    displayed
    
    However due to react-native limitations, the Splashscreen would not
    have the time to appear before the app is paused
    
    Then it would appear only when the app got the focus again
    
    The main impact is that when no Lock screen is needed, then we get the
    Splashscreen briefly displayed before seeing the app's content, which
    gives an impression of slowness
    
    When the Lock screen is needed, then we have the same effect but the
    Lock screen is displayed fast enough so the Splashscreen is not really
    needed
    
    By removing the Splashscreen we remove the slowness effect without
    losing any feature (the Lock screen appears fast enough)
    
    However we may want to revert this the day we find a way to force the
    Splashscreen BEFORE the app being sent to background
    Ldoppea committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a849a4a View commit details
    Browse the repository at this point in the history