fix: Don't show splashscreen before sending app to background #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing the Lock screen we tried to call the `showSplashScreen()` method before the app being sent to background This would prevent the app's content to be briefly displayed when going back to the app in the scenario where the Lock screen would need to be displayed However due to react-native limitations, the Splashscreen would not have the time to appear before the app is paused Then it would appear only when the app got the focus again The main impact is that when no Lock screen is needed, then we get the Splashscreen briefly displayed before seeing the app's content, which gives an impression of slowness When the Lock screen is needed, then we have the same effect but the Lock screen is displayed fast enough so the Splashscreen is not really needed By removing the Splashscreen we remove the slowness effect without losing any feature (the Lock screen appears fast enough) However we may want to revert this the day we find a way to force the Splashscreen BEFORE the app being sent to background
Ldoppea
force-pushed
the
fix/remove_splashscreen_before_lock
branch
from
e78ab8f
to
a849a4a
Compare
|
Just for information, you need this commit (or equivalent) to fix tests 6006dc2 |
|
Closing this PR in favor of: #894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing the Lock screen we tried to call the
showSplashScreen()method before the app being sent to backgroundThis would prevent the app's content to be briefly displayed when going back to the app in the scenario where the Lock screen would need to be displayed
However due to react-native limitations, the Splashscreen would not have the time to appear before the app is paused
Then it would appear only when the app got the focus again
The main impact is that when no Lock screen is needed, then we get the Splashscreen briefly displayed before seeing the app's content, which gives an impression of slowness
When the Lock screen is needed, then we have the same effect but the Lock screen is displayed fast enough so the Splashscreen is not really needed
By removing the Splashscreen we remove the slowness effect without losing any feature (the Lock screen appears fast enough)
However we may want to revert this the day we find a way to force the Splashscreen BEFORE the app being sent to background