chore(server): bump cosmossdk.io/core and correct comment naming

[hoank101]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Updated the dependency version for improved performance and stability.
  • Renamed methods for better consistency across services.

• Bug Fixes

  • Enhanced comment clarity for various methods to improve readability.

• Documentation

  • Updated documentation comments to reflect accurate struct names and functionality.

• Refactor

  • Standardized method names and variable names for better code maintainability.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request includes updates to various files within the server/v2 directory. Key changes involve updating the version of the cosmossdk.io/core dependency in the go.mod file, cosmetic modifications to comments in the abci.go, mock_reader.go, and mergeiter.go files for improved clarity, and renaming methods and variables in core_router_service.go and defaults.go to align with naming conventions. Overall, the changes maintain existing functionalities while enhancing code readability and consistency.

Changes

File Path	Change Summary
server/v2/appmanager/go.mod	Updated dependency version: cosmossdk.io/core from v1.0.0-alpha.3 to v1.0.0-alpha.4.
server/v2/cometbft/abci.go	Cosmetic changes to comments in the maybeRunGRPCQuery method; no functional changes.
server/v2/cometbft/internal/mock/mock_reader.go	Updated documentation comment for MockReader struct for clarity.
server/v2/stf/branch/mergeiter.go	Cosmetic changes to comments in the skipUntilExistsOrInvalid method; no functional changes.
server/v2/stf/core_router_service.go	Renamed method InvokeUntyped to Invoke in queryRouterService struct; method signature remains unchanged.
server/v2/stf/gas/defaults.go	Renamed variable DefaultGasConfig to DefaultConfig; no functional changes.

Possibly related PRs

• build(deps): bump to core v1.0.0-alpha.1 and remove replaces #21603: Updates the go.mod file to change the version of cosmossdk.io/core from v1.0.0 to v1.0.0-alpha.1, related to the main PR's update of the same dependency.
• build(deps): bump rocksdb & core & update ci codeowners #21652: Updates the go.mod files across modules, changing the version of cosmossdk.io/core from v1.0.0 to v1.0.0-alpha.1, aligning with the main PR's focus.
• chore: remove consensus authority  #21734: Involves changes to the Consensus struct in server/v2/cometbft/abci.go, relevant as it modifies the same file where the main PR also makes changes.
• feat(server/v2): refactor the server/v2 events #21785: Updates the version of cosmossdk.io/core from v1.0.0-alpha.3 to v1.0.0-alpha.4, which directly corresponds to the version change in the main PR.
• refactor(core/handlers): be more devx friendly #21984: Updates the version of cosmossdk.io/core from v1.0.0-alpha.3 to v1.0.0-alpha.4, which is directly related to the changes in the main PR.
• fix: update go module link #22003: Updates the CONTRIBUTING.md file, which may not be directly related to the code changes but reflects ongoing documentation efforts in conjunction with the main PR's updates.
• docs: Update build/abci docs #22067: Updates the documentation for build/abci, which may include references to the core module and its functionalities, indirectly relating to the changes in the main PR.
• docs(x/consensus): fixes #22114: Focuses on fixing documentation in the x/consensus module, which may relate to the core functionalities affected by the version changes in the main PR.
• docs: pre,begin,end block #22127: Updates documentation related to the pre, begin, and end block processes, which may be influenced by the changes in the core module's version in the main PR.
• chore: bring v0.52.0-beta.2 changelog to main #22188: Brings the changelog for version v0.52.0-beta.2 to the main branch, which may include references to the core module updates in the main PR.
• docs: fix rendering issue #22211: Addresses a rendering issue in the documentation, which may not directly relate to the code changes but reflects ongoing documentation improvements alongside the main PR's updates.

Suggested labels

backport/v0.52.x

Suggested reviewers

• facundomedica
• sontrinh16
• julienrbrt
• testinginprod
• akhilkumarpilli

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d2343c3 and 538be1b.

📒 Files selected for processing (1)

• server/v2/cometbft/abci.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• server/v2/cometbft/abci.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

server/v2/stf/core_router_service.go (1)

Line range hint 63-73: Approve the method renaming with a minor suggestion.

The renaming of InvokeUntyped to Invoke improves consistency with the msgRouterService implementation and adheres to the Uber Go Style Guide. The method signature and implementation are correct and follow good practices.

A minor suggestion to improve the comment:

-// Invoke execute a message and returns a response.
+// Invoke executes a query and returns a response.

This change more accurately reflects the purpose of the method in the context of a query router.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 65ed5eb and 7ae759f.

⛔ Files ignored due to path filters (1)

• server/v2/appmanager/go.sum is excluded by !**/*.sum

📒 Files selected for processing (6)

• server/v2/appmanager/go.mod (1 hunks)
• server/v2/cometbft/abci.go (1 hunks)
• server/v2/cometbft/internal/mock/mock_reader.go (1 hunks)
• server/v2/stf/branch/mergeiter.go (1 hunks)
• server/v2/stf/core_router_service.go (1 hunks)
• server/v2/stf/gas/defaults.go (1 hunks)

✅ Files skipped from review due to trivial changes (5)

• server/v2/appmanager/go.mod
• server/v2/cometbft/abci.go
• server/v2/cometbft/internal/mock/mock_reader.go
• server/v2/stf/branch/mergeiter.go
• server/v2/stf/gas/defaults.go

🧰 Additional context used

📓 Path-based instructions (1)

server/v2/stf/core_router_service.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.