Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): bump cosmossdk.io/core and correct comment naming (backport #22245) #22269

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Updated the dependency version for improved performance and stability.
    • Renamed methods for better consistency across services.
  • Bug Fixes

    • Enhanced comment clarity for various methods to improve readability.
  • Documentation

    • Updated documentation comments to reflect accurate struct names and functionality.
  • Refactor

    • Standardized method names and variable names for better code maintainability.

This is an automatic backport of pull request #22245 done by [Mergify](https://mergify.com).

)

(cherry picked from commit ee3d320)

# Conflicts:
#	server/v2/appmanager/go.mod
#	server/v2/appmanager/go.sum
#	server/v2/stf/core_router_service.go
#	server/v2/stf/gas/defaults.go
@mergify mergify bot requested a review from a team as a code owner October 15, 2024 14:07
Copy link
Contributor Author

mergify bot commented Oct 15, 2024

Cherry-pick of ee3d320 has failed:

On branch mergify/bp/release/v0.52.x/pr-22245
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit ee3d320ea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   server/v2/cometbft/abci.go
	modified:   server/v2/cometbft/internal/mock/mock_reader.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   server/v2/appmanager/go.mod
	deleted by us:   server/v2/appmanager/go.sum
	deleted by us:   server/v2/stf/core_router_service.go
	deleted by us:   server/v2/stf/gas/defaults.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@julienrbrt julienrbrt merged commit aab02ab into release/v0.52.x Oct 15, 2024
70 of 72 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22245 branch October 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants